Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates #280

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Dependency updates #280

merged 7 commits into from
Jan 17, 2024

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Jan 9, 2024 •
edited
Loading

Now that we have 1.75... we can bump all the things!

I'm keeping away from bumping -protocol now.

@rubdos
Copy link
Member Author

rubdos commented Jan 10, 2024

Cherry picked and fixed the protobuf dep from #270

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (926c555) 2.30% compared to head (bcae066) 3.39%.
Report is 4 commits behind head on main.

Files Patch % Lines
libsignal-service/src/groups_v2/model.rs 0.00% 12 Missing ⚠️
libsignal-service/src/utils.rs 0.00% 5 Missing ⚠️
libsignal-service/src/groups_v2/operations.rs 0.00% 2 Missing ⚠️
libsignal-service/src/groups_v2/manager.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #280      +/-   ##
========================================
+ Coverage   2.30%   3.39%   +1.09%     
========================================
  Files         34      37       +3     
  Lines       2478    2855     +377     
========================================
+ Hits          57      97      +40     
- Misses      2421    2758     +337

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubdos rubdos requested a review from gferon January 10, 2024 09:10
@rubdos rubdos changed the title Draft: dependency updates Dependency updates Jan 10, 2024
@rubdos rubdos mentioned this pull request Jan 10, 2024
Closed
@rubdos
Copy link
Member Author

rubdos commented Jan 10, 2024

Comparison is base (ce4ba97) 3.60% compared to head (f7a28d0) 17.25%.

Hmm. We didn't have libsignal-service in CI for testing and coverage, I added it here.

@rubdos
Copy link
Member Author

rubdos commented Jan 10, 2024

Bumps MSRV to 1.75 because of RPITIT. I anticipate this quickly will get traction in several libs.

@rubdos rubdos mentioned this pull request Jan 10, 2024
Merged
@rubdos
Copy link
Member Author

rubdos commented Jan 10, 2024

I saw some funky behaviour, the websocket seemed to be resetting.

2024-01-10T17:45:32.869635Z ERROR whisperfish::worker::client: Error starting stream: Websocket error: HTTP status 504 Gateway Timeout
2024-01-10T17:45:32.869732Z  INFO whisperfish::worker::client: Retrying in 10

2024-01-10T17:46:06.972704Z TRACE websocket: libsignal_service_hyper::websocket: Will start websocket at Url { scheme: "wss", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("chat.signal.org")), port: None, path: "/v1/websocket/", query: None, fragment: None }
2024-01-10T17:46:07.102194Z  WARN libsignal_service_hyper::websocket: Websocket closing: Some(CloseFrame { code: Error, reason: "org.eclipse.jetty.websocket.core.exception.WebSocketException: WebSocketResourceProvider OPEN method error: WebSocketConnec" })
2024-01-10T17:46:07.922719Z ERROR set up message receiver:websocket: libsignal_service::websocket: SignalWebSocket: Websocket error: end of web request stream; socket closing
2024-01-10T17:46:07.923564Z  INFO libsignal_service::messagepipe: sink was closed: Ok(())
2024-01-10T17:46:07.923604Z DEBUG whisperfish::worker::client: Attempting reconnect

@rubdos rubdos mentioned this pull request Jan 12, 2024
Merged
rubdos and others added 7 commits January 12, 2024 11:17
gferon
gferon approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@gferon gferon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 🚢 🚀

@rubdos rubdos merged commit 823f17b into main Jan 17, 2024
13 checks passed
@rubdos rubdos deleted the deps branch January 17, 2024 09:59
@Schmiddiii Schmiddiii mentioned this pull request Jan 17, 2024
Merged
@Schmiddiii Schmiddiii mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gferon gferon gferon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubdos @gferon